Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent watch stream from reconnecting after intentional pause or detach #771

Closed
chacha912 opened this issue Apr 9, 2024 · 0 comments
Closed
Labels
bug 🐞 Something isn't working

Comments

@chacha912
Copy link
Contributor

chacha912 commented Apr 9, 2024

What happened:

Even after intentionally pausing or detaching, the watch stream attempts to reconnect.
When pausing or detaching, the cancelWatchStream() function is called but due to the onDisconnect, the watch stream is reconnected. This results in the peer receiving unwatched events followed by watched events again.

What you expected to happen:

Upon pausing or detaching, only unwatched events should occur without attempting to reconnect the watch stream.

How to reproduce it (as minimally and precisely as possible):

unwatched.mov
  1. After running the quill-two-clients example, click on the manual sync button.
  2. Observe that unwatched events are triggered.
  3. Observe that watched events are triggered despite intentional pause.

Anything else we need to know?:

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version):
  • Yorkie JS SDK version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant