-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plain HTTP Health Check Endpoint #832
Comments
We need to add to also support NCP ALB. @hackerwins
Reference: https://guide.ncloud-docs.com/docs/loadbalancer-targetgroup-vpc#2-health-check-%EC%84%A4%EC%A0%95 |
Hello:) Could I work on this issue? |
@taeng0204 |
@taeng0204 If you want more context about this issue, please tell me. |
@krapie Are there any specific requirements or caveats to consider when setting up health checks in the Yorkie system? |
@taeng0204 All we need to do is to implement HEAD or GET HTTP health check endpoint, but we want to minimize the change to implement this. Current ConnectRPC's health check endpoint requires POST method with body, but if we can tweak or change the behavior with something like interceptors, it will be great. For more context, follow: https://bufbuild.slack.com/archives/CRZ680FUH/p1710158028178999 |
@krapie Thanks for the answer, but I thought that link was to the slack comment and it seems to have expired. |
@taeng0204 Can you check it again? |
@krapie Sorry, I tried a few times, but when I click on that link it says I can't see chats before April 17, 2024. https://bufbuild.slack.com/archives/CRZ680FUH/p1713373023394579 Can you give me the keywords for those chats? Then I'll do a search. |
@taeng0204 Below is the screenshot of the thread. |
@taeng0204 Any progress on this issue? |
@krapie There seem to be two ways to solve this issue. To do this, we need to make a setting in the proto file like this Here's an example from connectrpc/grpchealth-go // before
service Health {
rpc Check(HealthCheckRequest) returns (HealthCheckResponse);
...
}
// after
service Health {
rpc Check(HealthCheckRequest) returns (HealthCheckResponse){
option idempotency_level = NO_SIDE_EFFECTS;
}
...
} However, when I reached out to the Buf team via slack, I received the following response. Do you have a good idea to convince the Buf team? |
@taeng0204 I think it makes sense that gRPC don't have to consider about the HTTP method, because there is no "HTTP Method" concept in gRPC. And it seems like the Buf team is strictly following gRPC proto spec for the gRPC compatibility. Let's discuss about this in the following weekly-sync session. |
What would you like to be added:
Currently, our system only has the ConnectRPC health check endpoint
grpc.health.v1.Health/Check
, which requires an HTTP POST request with an application/json header and an empty body. This type of health checking is not convenient for common uptime checkers, especially free 3rd-party uptime checkers.To address this limitation, we should implement a simple Plain HTTP health check endpoint that can be accessed with an HTTP HEAD request for easier and more versatile health checking.
Why is this needed:
The current health check method is not user-friendly for common uptime checkers. Introducing a Plain HTTP health check endpoint will make it easier for users to monitor the health status of our system.
The text was updated successfully, but these errors were encountered: