From 16f33999bbb64543387ff3c827228ccb2c3eade1 Mon Sep 17 00:00:00 2001 From: yoshinorin Date: Tue, 2 May 2023 01:52:55 +0900 Subject: [PATCH] refactor: use `const` instead of `let` --- src/currentFile.ts | 6 +++--- src/editorChangeListner.ts | 2 +- src/extension.ts | 6 +++--- src/quickPicker.ts | 2 +- src/test/runSpecificVersionTest.ts | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/currentFile.ts b/src/currentFile.ts index d6e0f8d..60578f5 100644 --- a/src/currentFile.ts +++ b/src/currentFile.ts @@ -72,12 +72,12 @@ export class CurrentFile { ); } private set startsFromWorkSpaceHighestDirectoryPath(path: string) { - let folders = workspace.workspaceFolders; + const folders = workspace.workspaceFolders; if (folders === undefined) { this._startsFromWorkSpaceHighestDirectoryPath = path; return; } - let rootFolderObj = folders.find(x => { + const rootFolderObj = folders.find(x => { return this.toUnixStyle(path).startsWith( this.toUnixStyle(x.uri.fsPath) ); @@ -135,7 +135,7 @@ export class CurrentFile { } public update() { - let editor = window.activeTextEditor; + const editor = window.activeTextEditor; if (!editor) { this.statusBarItem.hide(); return; diff --git a/src/editorChangeListner.ts b/src/editorChangeListner.ts index e7a111d..8d11158 100644 --- a/src/editorChangeListner.ts +++ b/src/editorChangeListner.ts @@ -14,7 +14,7 @@ export class EditorChangeListner { constructor(currentFile: CurrentFile) { this._currentFile = currentFile; - let subscriptions: Disposable[] = []; + const subscriptions: Disposable[] = []; window.onDidChangeActiveTextEditor(this._onEvent, this, subscriptions); this._disposable = Disposable.from(...subscriptions); } diff --git a/src/extension.ts b/src/extension.ts index ef87603..ccc896c 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -5,10 +5,10 @@ import { CurrentFile } from "./currentFile"; import { EditorChangeListner } from "./editorChangeListner"; export function activate(context: ExtensionContext) { - let currentFile = new CurrentFile(); - let listner = new EditorChangeListner(currentFile); + const currentFile = new CurrentFile(); + const listner = new EditorChangeListner(currentFile); - let disposableCommands = [ + const disposableCommands = [ commands.registerCommand( "currentFilePath.executeQuickPickerAction", () => { diff --git a/src/quickPicker.ts b/src/quickPicker.ts index eb3babe..fedd3fb 100644 --- a/src/quickPicker.ts +++ b/src/quickPicker.ts @@ -90,7 +90,7 @@ export class QuickPicker { }); - let selectedAction = await window.showQuickPick(this._pickItems, { + const selectedAction = await window.showQuickPick(this._pickItems, { placeHolder: "Select" }); diff --git a/src/test/runSpecificVersionTest.ts b/src/test/runSpecificVersionTest.ts index 9e3f840..e1f7aef 100644 --- a/src/test/runSpecificVersionTest.ts +++ b/src/test/runSpecificVersionTest.ts @@ -9,7 +9,7 @@ async function main() { const extensionTestsPath = path.resolve(__dirname, './suite/index'); // v1.45.0 test - let vscodeExecutablePath = await downloadAndUnzipVSCode('1.45.0'); + const vscodeExecutablePath = await downloadAndUnzipVSCode('1.45.0'); try { await runTests({ vscodeExecutablePath,