-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass TestUserNamespaces of contaienrd #1277
Comments
The Youki Logs :
Somethings that I notice here are : use_systemd is None, it should probably be some(...) ? Also, this starts a rootless container? Should these two be the way they are? because in exec tests, the containers were not rootless, ans systemd was Some(false) |
Also, this makes me question why do we have use_systemd in Option, if it is bool. It can be either to use it or not to use it, in which case we can se appropriate default value of it, rather than having to keep it None. |
I did try making the use_systemd as bool, with default false ( as unless explicitly stated, we should not be using systemd) . That does not solve this issue, so the points I mentioned above might not be why the test is not passing |
On doing more digging, this is possibly due to we setting the cgroups path incorrectly. Will update if find something concrete |
https://github.com/containerd/containerd/blob/4bd8b5be444a8c381db7fa678def3bb6d416d0e1/integration/client/container_linux_test.go#L1123
Error message
The text was updated successfully, but these errors were encountered: