-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container ID validation #1580
Comments
Hey @lengrongfu , can you give a bit more info on where this function will be used? For example, right now we validate the id to be non-zero length in the cli parsing. Similarly, where would these validation be used? |
We can add a logic to call |
Ok, I guess that will help us keep compatibility with runc... That said, we are trying to be compatible with other runtimes, so it would be a good idea to validate id to be "correct" as per them. Sure, you can go ahead and open a PR for this, thanks a lot for pointing this out, and showing interest in adding the change :) |
Current
youki
not container ID validate, butrunc
is having, https://github.com/opencontainers/runc/blob/537645fd52e97e1e33f3b6b8d71397affada9779/libcontainer/factory_linux.go#L278Can I add this logic for
youki
?The text was updated successfully, but these errors were encountered: