Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non deterministic output for non-ascii character #3

Open
AndreiDumitrescu26 opened this issue May 24, 2024 · 3 comments
Open

Non deterministic output for non-ascii character #3

AndreiDumitrescu26 opened this issue May 24, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@AndreiDumitrescu26
Copy link

Running this command multiple times generates unexpected different outputs:

fast_edit_distance.edit_distance(
     '€24,99|€  20,65|€ 24,99|€4,34|€24,99|€  24,99|€  24,99|',
     '1'
)
@AndreiDumitrescu26
Copy link
Author

It seems to happen because "€" is a non-ascii character.

@youyupei youyupei closed this as completed Aug 3, 2024
@martinloretzzz
Copy link

martinloretzzz commented Oct 25, 2024 •
edited
Loading

Same problem with strings like edit_distance("!", "¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯")

@youyupei
Copy link
Owner

Yes, it doesn't handle non-ascii character at the moment, will leave the issue open until fixed

@youyupei youyupei reopened this Oct 25, 2024
@youyupei youyupei added bug Something isn't working enhancement New feature or request labels Oct 25, 2024
@youyupei youyupei changed the title Non deterministic output Non deterministic output for non-ascii character Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinloretzzz @youyupei @AndreiDumitrescu26