Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrapping of cyclical data #4

Open
nup002 opened this issue Mar 20, 2024 · 3 comments
Open

Unwrapping of cyclical data #4

nup002 opened this issue Mar 20, 2024 · 3 comments
Assignees

Comments

@nup002
Copy link

nup002 commented Mar 20, 2024

I would love to give Kamui a try in my particular application where I am tasked with unwrapping weighted gridded data with one cyclical axis. However, I do not understand the algorithm well enough to figure out how to implement cyclical axes. An example of how to unwrap 2D data with one cyclical axis would be highly appreciated. Ideally, this functionality would be part of the library itself with an optional cyclical_axis keyword.

@yoyolicoris
Copy link
Owner

Hi @nup002 , thanks for asking. That sounds like a good idea and can be easily added.

The type of cyclical_axis will be Union[Int, Tuple[Int]], in the case of multiple cyclical axes.
I'll find a time to do it.

@yoyolicoris yoyolicoris self-assigned this Apr 1, 2024
@yoyolicoris yoyolicoris moved this from Todo to In Progress in @yoyololicon's Kanban Apr 2, 2024
@yoyolicoris yoyolicoris moved this from In Progress to Reviewing in @yoyololicon's Kanban Apr 2, 2024
@yoyolicoris
Copy link
Owner

Hi @nup002,

The cyclical axis feature is added to the dev branch (5ea1b10).
If you have time, could you help me test if it work in your case.

@nup002
Copy link
Author

nup002 commented Apr 11, 2024

Hello @yoyololicon ,
I am really excited to try this out! I will get back to you once I've had a go at using it, to provide feedback. It may take a few weeks, as we have a lot of higher-priority tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Reviewing
Development

No branches or pull requests

2 participants