Google icons do not belong to the right web

[cdiazbas]

Info:

• OS: 12.6.5
• Logseq ver: 0.9.4
• Plugin ver: v1.15.16
• Theme name: any theme

Description:
All the link regarding google.com (documents, presentations, spreadsheets, etc) have the same icon. It looks like they are taking it from the last google page or something like that. When I open the app, they look right, but after going to any page, they update is wrong. Moreover, google drive have the "Google" icon instead of the google-drive icon.

Screenshots

[dwradcliffe]

I'm still seeing this too

[gabetax]

The source of the bug is that the favIconsCache uses the link's "hostname" as a cache key:

logseq-awesome-links/src/modules/favIcons/favIcons.ts

Lines 42 to 49 in 9db3577

	if (globals.favIconsCache.has(hostname)) {
	// try from cache
	faviconData = globals.favIconsCache.get(hostname);
	} else {
	// no? get fresh + save to cache
	faviconData = await getFaviconData(url);
	globals.favIconsCache.set(hostname, faviconData);
	}

When there's a cache hit, it skips the special-cased path checks specific to Google Docs at:

logseq-awesome-links/src/modules/favIcons/favIcons.ts

Lines 119 to 136 in 9db3577

	if (url.includes('docs.google.com/document')) {
	return favIcon = {
	format: 'img',
	src: await getBase64FromUrl(`https://ssl.gstatic.com/docs/documents/images/kix-favicon7.ico`)
	}
	}
	if (url.includes('docs.google.com/spreadsheets')) {
	return favIcon = {
	format: 'img',
	src: await getBase64FromUrl(`https://ssl.gstatic.com/docs/spreadsheets/favicon3.ico`)
	}
	}
	if (url.includes('docs.google.com/presentation')) {
	return favIcon = {
	format: 'img',
	src: await getBase64FromUrl(`https://ssl.gstatic.com/docs/presentations/images/favicon5.ico`)
	}
	}

I also observed that if you refresh the Logseq window (e.g. Cmd+R) we display the correct icons, because there's a race with the cache being empty.

I'm not clear on whether the intent of the favIconsCache is to exclusively skip the HTTP fetches, or if there's observable compute savings for the local inlined <svg ... tags too. But if not, maybe the cache concern could be lifted into getBase64FromUrl, so the cache key could just be the URL of the favicon instead of the hostname of the link?

Thoughts @yoyurec?