Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java version compatibility #60

Closed
sanders9 opened this issue Oct 12, 2021 · 2 comments · Fixed by #62
Closed

Java version compatibility #60

sanders9 opened this issue Oct 12, 2021 · 2 comments · Fixed by #62
Labels
bug Something isn't working contribution welcome good first issue Good for newcomers

Comments

@sanders9
Copy link

It'd seem that since 0.10.1 the java compatibility has been broken.

Kotlin: 1.5.30
Gradle: 7.2
BuildKonfig: since 0.10.1
Gradle JVM : 1.8
@yshrsmz
Copy link
Owner

yshrsmz commented Oct 13, 2021 •
edited
Loading

It's most likely because I upgraded my local/CI JDK to 11 to use Android Gradle Plugin v7.
I wonder if setting sourceCompatibility and targetCompatibility to 1.8 work. I'll do that in the next release.

Or would you like to send a PR? Then I can cut a patch release with that.

@yshrsmz yshrsmz added bug Something isn't working contribution welcome good first issue Good for newcomers labels Oct 13, 2021
@yshrsmz yshrsmz mentioned this issue Oct 18, 2021
Merged
@yshrsmz
Copy link
Owner

yshrsmz commented Oct 20, 2021

hi v0.11.0 is out with the above modifications. Please let me know if we need further action. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working contribution welcome good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set source/target compatibility to 1.8 yshrsmz/BuildKonfig
2 participants
@yshrsmz @sanders9