Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging related to shader loading #1394

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix logging related to shader loading #1394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4b3b3
close file after read
l4desu-mizu Dec 9, 2024
c050f89
fix misleading error message when using shader rules
l4desu-mizu Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/picom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,7 @@ static bool load_shader_source(session_t *ps, const char *path) {
path, read_bytes, num_bytes);
goto err;
}
fclose(f);
return false;
err:
HASH_DEL(ps->shaders, shader);
Expand Down Expand Up @@ -2076,7 +2077,7 @@ static session_t *session_init(int argc, char **argv, Display *dpy,

// Load shader source file specified in the shader rules
c2_condition_list_foreach(&ps->o.window_shader_fg_rules, i) {
if (!load_shader_source(ps, c2_condition_get_data(i))) {
if (load_shader_source(ps, c2_condition_get_data(i))) {
log_error("Failed to load shader source file for some of the "
"window shader rules");
}
Expand Down