Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: plot.hide_axes(show_frame=True) is broken #3852

Closed
neutrinoceros opened this issue Mar 20, 2022 · 4 comments · Fixed by #3849
Closed

BUG: plot.hide_axes(show_frame=True) is broken #3852

neutrinoceros opened this issue Mar 20, 2022 · 4 comments · Fixed by #3849

Comments

@neutrinoceros
Copy link
Member

neutrinoceros commented Mar 20, 2022

Bug report

Bug summary
The show_frame argument has no effect
This is visible in the second-to-last example in this docs section
https://yt-project.org/doc/visualizing/plots.html#colormaps

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Mar 20, 2022

Oh, so it's not that it doesn't work, it's really just that the explanation is superfluous and confusing (though there were good reasons for it at the time).
It can be replaced by a runtime warning within #3849

@chummels
Copy link
Member

chummels commented Aug 5, 2022

I'm looking at the docs example you've linked, and there is no reference to a show_frame kwarg in plot.hide_axes, but there is a draw_frame kwarg. Is that what you mean? Also, according to that documentation, it does seem to be working, as it enables the use of the set_background_color(). So I'm confused how this is a bug at all. But maybe I'm misunderstanding what you're describing in this bug report.

@neutrinoceros
Copy link
Member Author

there is a draw_frame kwarg. Is that what you mean?

indeed, my mistake.

it does seem to be working, as it enables the use of the set_background_color().

You're right. I guess I was confused by the name and expected some frame to show around the figure, not the background itself. Even reading it now I find this documentation confusing :/

@neutrinoceros
Copy link
Member Author

I tried to retro-engineer my own thought process and couldn't make sense of this. I also linked #3849 here but I don't see any difference in behaviour between the main branch and that one, so I'm going to say "case closed" here.

Unrelated but there's also some good news for this particular example in the docs, the latest build (yt 4.0.2) produced this image
Screenshot 2022-08-08 at 15 11 53

And now (main branch) we're getting this
1_branch

I wouldn't be surprised that this was fixed with #4050

anyway, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants