Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: eps_writer.multiplot_yt regression in yt 4.1 #4215

Closed
neutrinoceros opened this issue Nov 17, 2022 · 1 comment · Fixed by #4216
Closed

BUG: eps_writer.multiplot_yt regression in yt 4.1 #4215

neutrinoceros opened this issue Nov 17, 2022 · 1 comment · Fixed by #4216
Assignees
Milestone

Comments

@neutrinoceros
Copy link
Member

neutrinoceros commented Nov 17, 2022

Bug report

Bug summary

This bug was reported on Slack by @mihirskulkarni, I've started minimizing the reproducer script

Code for reproduction

import yt
import yt.visualization.eps_writer as eps
from yt.testing import fake_amr_ds

ds = fake_amr_ds(
    fields=[("gas", "density"), ("gas", "temperature")],
    units=["g/cm**3", "K"]
)

slc = yt.SlicePlot(
    ds,
    "y",
    [
        ("gas", "density"),
        ("gas", "temperature"),
    ],
)
eps_fig = eps.multiplot_yt(2, 1, slc)

Actual outcome

...
AttributeError: 'WindowPlotMPL' object has no attribute 'zmin'

This script worked on yt 4.0.5 and is broken since yt 4.1.0
The exact commit that this regression happened is 379c082... This is an oversight from #3849

I'll work on a patch

@neutrinoceros neutrinoceros added this to the 4.1.2 milestone Nov 17, 2022
@neutrinoceros neutrinoceros self-assigned this Nov 17, 2022
@neutrinoceros
Copy link
Member Author

Actually it seems that the one test in yt/visualization/tests/test_eps_writer.py is broken too, so my guess is that it is currently not run on any CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant