Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytdata IOHandlers: data_file index ranges? #4596

Open
chrishavlin opened this issue Jul 24, 2023 · 4 comments
Open

ytdata IOHandlers: data_file index ranges? #4596

chrishavlin opened this issue Jul 24, 2023 · 4 comments

Comments

@chrishavlin
Copy link
Contributor

chrishavlin commented Jul 24, 2023

In working on #4595 and #4565, I found that the _read_particle_coords and _read_particle_fields implementations don't generally use the data_file.start and data_file.end indices when looping over chunks. For IOHandlerYTDataContainerHDF5, this seemed like a clear bug, so #4595 only fixes it for that handler.

Looking through the other handlers -- it looks to me like the IOHandlerYTSpatialPlotHDF5 (link to code) implementations of _read_particle_coords and _read_particle_fields should be updated to use the start and end index ranges as well. Anyone have thoughts on that?

I think the other classes should be OK since they don't over-ride the particle reader functions.

@chrishavlin
Copy link
Contributor Author

Pinging a few folks who might have insight here: @brittonsmith @matthewturk

@brittonsmith
Copy link
Member

This is most likely an oversight from when file chunking was implemented. If it's not using start and end, this probably needs to be fixed.

@chrishavlin
Copy link
Contributor Author

OK, I'll get in a similar fix to use the index ranges then. Thanks!

@brittonsmith
Copy link
Member

Thanks for taking care that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants