You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In working on #4595 and #4565, I found that the _read_particle_coords and _read_particle_fields implementations don't generally use the data_file.start and data_file.end indices when looping over chunks. For IOHandlerYTDataContainerHDF5, this seemed like a clear bug, so #4595 only fixes it for that handler.
Looking through the other handlers -- it looks to me like the IOHandlerYTSpatialPlotHDF5 (link to code) implementations of _read_particle_coords and _read_particle_fields should be updated to use the start and end index ranges as well. Anyone have thoughts on that?
I think the other classes should be OK since they don't over-ride the particle reader functions.
The text was updated successfully, but these errors were encountered:
In working on #4595 and #4565, I found that the
_read_particle_coords
and_read_particle_fields
implementations don't generally use thedata_file.start
anddata_file.end
indices when looping over chunks. ForIOHandlerYTDataContainerHDF5
, this seemed like a clear bug, so #4595 only fixes it for that handler.Looking through the other handlers -- it looks to me like the
IOHandlerYTSpatialPlotHDF5
(link to code) implementations of_read_particle_coords
and_read_particle_fields
should be updated to use thestart
andend
index ranges as well. Anyone have thoughts on that?I think the other classes should be OK since they don't over-ride the particle reader functions.
The text was updated successfully, but these errors were encountered: