Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: tests fail on Python 3.8 #168

Closed
neutrinoceros opened this issue Jan 5, 2023 · 0 comments · Fixed by #169
Closed

BUG: tests fail on Python 3.8 #168

neutrinoceros opened this issue Jan 5, 2023 · 0 comments · Fixed by #169
Labels
bug
Milestone
1.1.2

Comments

@neutrinoceros
Copy link
Member

Seems like we overlooked a deprecation cycle

AttributeError: module 'numpy' has no attribute 'float'

numpy.float was deprecated in numpy 1.20 and removed in 1.24, because it was counter-intuitively just aliasing builtin float. So the conservative fix is just to use float.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.2
Development

Successfully merging a pull request may close this issue.

BUG: fix compatibility with numpy 1.24 (numpy.float was removed) neutrinoceros/yt_astro_analysis
1 participant
@neutrinoceros