Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVP - proposed REGEX fix for tvp.py extractor #19249

Closed
5 of 9 tasks
the-researcher opened this issue Feb 17, 2019 · 1 comment
Closed
5 of 9 tasks

TVP - proposed REGEX fix for tvp.py extractor #19249

the-researcher opened this issue Feb 17, 2019 · 1 comment

Comments

@the-researcher
Copy link

the-researcher commented Feb 17, 2019

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other


bug report for Telewizja Polska (TVP)

[debug] System config: [u'--output', u'/mnt/emmc/youtube-dl/']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 2.7.13 (CPython) - Linux-4.14.66+-armv7l-with-debian-9.7
[debug] exe versions: ffmpeg 3.2.12-1, ffprobe 3.2.12-1
[debug] Proxy map: {}

As referenced in #7799, the REGEX logic is not working when pasting in video URLs.

Proposed fix:

https://regex101.com/r/aubLoI/4

This simply re-parses the film link to the /sess/player/video/ link format, with the numerical UUID of the video pasted onto the end of the link, which can then be processed by youtube-dl. Exmaples provided at the link with the suggested REGEX, as well as test cases. As long as the link pasted is of the vod.tvp.pl/video/ variety, it should use this REGEX to fix the parse and pull of youtube-dl.

@the-researcher
Copy link
Author

@dstftw

Can you describe why this issue was flagged as closed/incomplete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants