From a9806fd83d7efc4cc1dcd11174c839f637d0c105 Mon Sep 17 00:00:00 2001 From: Vasyl' Vavrychuk Date: Sun, 5 Dec 2010 20:48:22 +0200 Subject: [PATCH 1/2] report_extraction was never called for GenericIE --- youtube-dl | 1 + 1 file changed, 1 insertion(+) diff --git a/youtube-dl b/youtube-dl index 22dd230ee2b..d0584a3126c 100755 --- a/youtube-dl +++ b/youtube-dl @@ -1619,6 +1619,7 @@ class GenericIE(InfoExtractor): self._downloader.trouble(u'ERROR: Invalid URL: %s' % url) return + self.report_extraction(video_id) # Start with something easy: JW Player in SWFObject mobj = re.search(r'flashvars: [\'"](?:.*&)?file=(http[^\'"&]*)', webpage) if mobj is None: From 6f0ff3bab9f213790817e3344bb5025a7fbea1e4 Mon Sep 17 00:00:00 2001 From: Vasyl' Vavrychuk Date: Sun, 5 Dec 2010 20:57:46 +0200 Subject: [PATCH 2/2] Fixed failure of os.rename after receiving file finished due to file not being closed. Following error happen while at the end of _do_download called try_rename WindowsError: [Error 32] The process cannot access the file because it is being used by another process --- youtube-dl | 1 + 1 file changed, 1 insertion(+) diff --git a/youtube-dl b/youtube-dl index d0584a3126c..6b5f5693d25 100755 --- a/youtube-dl +++ b/youtube-dl @@ -640,6 +640,7 @@ class FileDownloader(object): # Apply rate limit self.slow_down(start, byte_counter) + stream.close() self.report_finish() if data_len is not None and str(byte_counter) != data_len: raise ContentTooShortError(byte_counter, long(data_len))