Enabled GEO tests after fix #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjalan-yb
reviewed
Feb 16, 2024
| @@ -258,6 +258,8 @@ def send_report_to_reportportal( | |||
| logging.error(f"Code: {response.status_code} Text: {response.text}") | |||
| return False | |||
|
|
|||
| return True | |||
There was a problem hiding this comment.
Instead of returning True here, should not we remove else statement and put return in if clause. That makes more sense. Because we have an if clause but no return statement there.
if response.status_code == 200:
logging.info(f"Successfully updated attributes for launch {launch_id}")
return True
logging.error(f"Could not update attributes for launch {launch_id}")
logging.error(f"Code: {response.status_code} Text: {response.text}")
return False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.