Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docdb] PITR-YSQL: Support with Tablespaces #10257

Closed
kripasreenivasan opened this issue Oct 12, 2021 · 0 comments
Closed

[docdb] PITR-YSQL: Support with Tablespaces #10257

kripasreenivasan opened this issue Oct 12, 2021 · 0 comments
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@kripasreenivasan
Copy link
Contributor

kripasreenivasan commented Oct 12, 2021

Jira Link: DB-636
Observed in builds: 2.8.0.0 b5, 2.9.1.0 b 132
With geo-partition being requirement, we need to ensure PITR support with tablespaces. Tablespace information is stored in the pg_tablespace system table which is global and not shared by databases. Currently, we don't restore the global objects of pg_catalog. For e.g. one scenario where this will have consequences:

  1. Create a tablespace
  2. Create a few tables that are a part of the tablespace created in (1)
  3. Drop these tables
  4. Drop the tablespace
  5. Restore to a point after (2)

Since pg_tablespace isn't restored, the tablespace will continue to remain dropped even after restore leading to a failure in restoring the tables. There are several approaches we could take to mitigate this:

  1. We could disable Drops on tablespaces - this would ensure that any table that we restore will have the corresponding tablespace information present always.
  2. We could restore pg_tablespace as well - this can have unintended consequences because we might end up dropping some tablespaces containing tables of other databases.

Also, how does this interplay with the Alter Tablespace feature that we intend to support?

@kripasreenivasan kripasreenivasan changed the title PITR: Table not getting removed post restore when coupled with a tablspace PITR: Table not getting removed post restore when coupled with a tablespace Oct 12, 2021
@sanketkedia sanketkedia changed the title PITR: Table not getting removed post restore when coupled with a tablespace [docdb] PITR: Support with Tablespaces Oct 19, 2021
@sanketkedia sanketkedia changed the title [docdb] PITR: Support with Tablespaces [docdb] PITR-YSQL: Support with Tablespaces Oct 19, 2021
@sanketkedia sanketkedia added the area/docdb YugabyteDB core features label Oct 19, 2021
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 2, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jul 30, 2022
@yugabyte-ci yugabyte-ci closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants