Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Colocation - Dropping a colocated table does not remove it from table list of SysTabletsEntryPB #14609

Open
sanketkedia opened this issue Oct 21, 2022 · 2 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@sanketkedia
Copy link
Contributor

sanketkedia commented Oct 21, 2022

Jira Link: DB-3979

Description

When a colocated table is completely DELETED (not HIDDEN), it is not removed from the table_ids list of SysTabletsEntryPB of the colocated tablet. Given that the table has no chance of coming back, we should remove it from this list as well. We have a couple of places in the code where we log a warning if tables from this list aren't found in the cluster because of this reason; they should also be modified to FATAL so that other types of genuine bugs such as corruption can be detected.

@sanketkedia sanketkedia added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Oct 21, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Oct 21, 2022
@yifanguan
Copy link
Contributor

Duplicate of #11129.

@yifanguan
Copy link
Contributor

yifanguan commented Mar 7, 2023

This original issue is solved because of commit 98645ac. It changes the way we persist the info of the set of tables hosted on a colocated tablet on master.
However, with this new schema of SysTabletsEntryPB, we keep one table_ids_ list in memory in TabletInfo. Not sure what can happen, if we do not remove deleted tables from this in memory table_ids_.

  // Transient, in memory list of table ids hosted by this tablet. This is not persisted.
  // Only used when FLAGS_use_parent_table_id_field is set.
  std::vector<TableId> table_ids_ GUARDED_BY(lock_);

Thus, I leave this issue open but move out of the colocation epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants