Thirdparty package compile error while using GCC8

[graffido]

thirdparty package build failed using GCC8, cause unrecognize "gcc8_uninstrumented" build type.

YB_LINUXBREW_DIR=undefined
YB_CUSTOM_HOMEBREW_DIR=undefined
Unsetting CC for third-party build (was set to "/var/lib/jenkins/workspace/yugabyte/build-support/compiler-wrappers/cc").
Unsetting CXX for third-party build (was set to "/var/lib/jenkins/workspace/yugabyte/build-support/compiler-wrappers/c++").
usage: /var/lib/jenkins/workspace/yugabyte/thirdparty/yb_build_thirdparty_main.py
       [-h]
       [--build-type {common,uninstrumented,clang_uninstrumented,asan,tsan}]
       [--skip-sanitizers] [--clean] [--add_checksum] [--skip SKIP]
       [-j MAKE_PARALLELISM]
       ...
/var/lib/jenkins/workspace/yugabyte/thirdparty/yb_build_thirdparty_main.py: error: argument --build-type: invalid choice: 'gcc8_uninstrumented' (choose from 'common', 'uninstrumented', 'clang_uninstrumented', 'asan', 'tsan')
/var/lib/jenkins/workspace/yugabyte/thirdparty/build_definitions
CMake Error at CMakeLists.txt:564 (message):
  Thirdparty was built unsuccessfully, terminating.


-- Configuring incomplete, errors occurred!

[graffido]

Solution:

- BUILD_TYPES = [BUILD_TYPE_COMMON, BUILD_TYPE_UNINSTRUMENTED, BUILD_TYPE_CLANG_UNINSTRUMENTED,
               BUILD_TYPE_ASAN, BUILD_TYPE_TSAN]
+ BUILD_TYPES = [BUILD_TYPE_COMMON, BUILD_TYPE_UNINSTRUMENTED, BUILD_TYPE_CLANG_UNINSTRUMENTED,
               BUILD_TYPE_GCC8_UNINSTRUMENTED, BUILD_TYPE_ASAN, BUILD_TYPE_TSAN]

@ thirdparty/build_definitions/init.py

[rkarthik007]

Hi @graffido - thanks for investigating this! Seems like a good fix. Could you please add yourself to the list of contributors: https://github.com/yugabyte/yugabyte-db/blob/master/CONTRIBUTORS.md

cc @mbautin @bmatican @ttyusupov @iSignal

[graffido]

thanks @rkarthik007 , submitted a PR for this issue at https://github.com/yugabyte/yugabyte-db/pull/3691

[mbautin]

Builds with gcc8 have been working fine for some time.