Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yql]: Add yql to its -jsonp, -nodejs, -winjs submodules. #1737

Merged
merged 3 commits into from
Mar 31, 2014

Conversation

ezequiel
Copy link
Contributor

@caridy @juandopazo

Is the coast clear?

@yahoocla
Copy link

CLA is valid!

@@ -9,6 +9,7 @@
"when": "after"
},
"requires": [
"yql",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one makes sense because the script is modifying a prototype defined in yql module.

@ezequiel
Copy link
Contributor Author

This is unnecessary. Closing.

@ezequiel ezequiel closed this Mar 28, 2014
@ezequiel ezequiel deleted the yql-meta branch March 29, 2014 03:01
@ezequiel
Copy link
Contributor Author

@caridy, @juandopazo:

After thinking about this a little further, I agree with this change.

What stops a user from writing use("yql-jsonp")? Why shouldn't they? Sure, you could argue this particular module is not meant to be used in this manner, but it can if the user wishes to. It is a separate module you can include. It is in the build directory.

Why should their program error should they wish to include yql-jsonp via that style? If YUI did not want for someone to use("yql-jsonp") in that style, then it should not have been made a separate module in the first place.

For a reproduction, see: http://jsbin.com/rapakuve/1/edit

@ezequiel ezequiel restored the yql-meta branch March 31, 2014 21:24
@ezequiel ezequiel reopened this Mar 31, 2014
@caridy
Copy link
Member

caridy commented Mar 31, 2014

LGTM

remember to update the history entries.

@ezequiel
Copy link
Contributor Author

Thanks.

@ezequiel ezequiel merged commit 44f28b7 into yui:dev-master Mar 31, 2014
@ezequiel ezequiel deleted the yql-meta branch April 11, 2014 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants