Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to mount non existing file #3

Closed
mrhotio opened this issue Sep 16, 2020 · 7 comments
Closed

Fails to mount non existing file #3

mrhotio opened this issue Sep 16, 2020 · 7 comments

Comments

@mrhotio
Copy link

mrhotio commented Sep 16, 2020

When not using a config-file, the docker run command tries to mount a default file regardless, which fails.

@mrhotio
Copy link
Author

mrhotio commented Sep 16, 2020

Or am I misinterpreting the usage, maybe a config file is always required, but I'm not required to configure one?

@mrhotio
Copy link
Author

mrhotio commented Sep 16, 2020

It seems that Dive always expects a config file...maybe provide a default config file if the user does not make use of config-file input.....?

@yuichielectric
Copy link
Owner

@hotio Sorry for the delay in replying, the config-file isn't required, dive has a default CI setting, so it should be run using that setting.
I've made some modifications since then, could you try again with the following settings?

I ran it in this repository without config-file and made sure it worked.
https://github.com/yuichielectric/dockerfile-ci-sample/blob/cb6d6a5f7500187b175519f3aa61ee9c866de810/.github/workflows/dive-ci.yml

@mrhotio
Copy link
Author

mrhotio commented Sep 28, 2020

Still getting the same error with:


      - name: Dive Analysis
        uses: yuichielectric/dive-action@0.0.3
        with:
          image: "${{ steps.prep.outputs.tag }}"

https://github.com/hotio/docker-hd-idle/runs/1175314154?check_suite_focus=true#step:10:23

@yuichielectric
Copy link
Owner

Thanks, I was able to reproduce it in my repository. I'll fix it soon.

@yuichielectric
Copy link
Owner

I've fixed this bug and released 0.0.4. I confirmed that it works fine without passing config-file parameter. Can you try again with 0.0.4 ?

@mrhotio
Copy link
Author

mrhotio commented Sep 28, 2020

yep works now

@mrhotio mrhotio closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants