Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Launchy #21

Closed
wants to merge 7 commits into from
Closed

Support for Launchy #21

wants to merge 7 commits into from

Conversation

RobinDaugherty
Copy link
Contributor

This PR relies on the changes that are in #19, so that PR must be merged before this one.

Add support for the launchy option, which mirrors behavior that the guard-rspec plugin supports. For example:

guard :rubocop, cli: %w(--format fuubar --format html -o ./tmp/rubocop_results.html), launchy: './tmp/rubocop_results.html' do
  # ...
end

This will cause the Rubocop results to be opened in the default browser when the guard runs, in addition to being output in the terminal.

e2 and others added 5 commits December 11, 2014 14:08
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 736d49f on Ahalogy:launchy into dffc18d on yujinakayama:master.

This cribs some code from the guard-rspec plugin.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 11a85a9 on Ahalogy:launchy into dffc18d on yujinakayama:master.

@RobinDaugherty
Copy link
Contributor Author

To satisfy rubocop running on Travis CI (the only reason for the build failure) the following changes need to be made:

  • PR Conform to Ruby style guide on %r #17 or something equivalent. At this time, the changes in that are suspect (is that regex really equivalent, or is it fixing a bug?) but the syntax change needs to be made.
  • Refactoring the Runner class to make it shorter. I think the way that guard-rubocop does it is probably the right way: adding a Notifier class. It might also make sense to add an Options class as well.

I'm hoping to make these changes, but I probably won't be able to do it soon.

@yujinakayama
Copy link
Collaborator

Merged via #35. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants