Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes run_on_changes to run_on_modifications #6

Closed
wants to merge 2 commits into from
Closed

Changes run_on_changes to run_on_modifications #6

wants to merge 2 commits into from

Conversation

davejlong
Copy link

This fixes an issue with Vim where the task will run multiple times when a file is saved.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.17%) when pulling 4d186f3 on davejlong:patch-1 into b498bd2 on yujinakayama:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a10e1a4 on davejlong:patch-1 into b498bd2 on yujinakayama:master.

@yujinakayama
Copy link
Collaborator

Thanks for the PR, but there are a few concerns:

  • I'm not sure whether this implementation is a right way, because the reason why guard-rubocop runs multiple times with your Vim is still unclear.
  • With this change, guard-rubocop won't run on creation of a new file.

@killphi
Copy link

killphi commented Dec 1, 2013

guard/guard#495 as to why run_on_modifications is better suited for certain editors

and for your second point, may I direct you to the Guard Wiki
If I understand run_on_additions correctly, it would solve the second concern

cheers

@yujinakayama
Copy link
Collaborator

@killphi Thanks for the information. I'll handle it.

@killphi
Copy link

killphi commented Dec 2, 2013

Thanks for considering it.
I could've spared me some work, if I'd just looked at the pull requests beforehand :)

yujinakayama added a commit that referenced this pull request Dec 2, 2013
@yujinakayama
Copy link
Collaborator

Released 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants