Use str instead of repr in typename, fixing Union[Literal["str"], ...]

serde/compat.py

@@ -212,7 +212,7 @@ def typename(typ, with_typing_module: bool = False) -> str:
         args = type_args(typ)
         if not args:
             raise TypeError("Literal type requires at least one literal argument")
-        return f'Literal[{", ".join(repr(e) for e in args)}]'
+        return f'Literal[{", ".join(str(e) for e in args)}]'
     elif typ is Any:
         return f'{mod}Any'
     else:

tests/test_compat.py

@@ -3,6 +3,12 @@
 from datetime import datetime
 from typing import Dict, Generic, List, NewType, Optional, Set, Tuple, TypeVar, Union
 
+if sys.version_info[:2] == (3, 7):
+    from typing_extensions import Literal
+else:
+    from typing import Literal
+
+
 import serde
 from serde.compat import (
     is_dict,
@@ -84,6 +90,7 @@ class Foo(Generic[T]):
     assert typename(Dict[str, Foo]) == "Dict[str, Foo]"
     assert typename(Set) == "Set"
     assert typename(Set[int]) == "Set[int]"
+    assert typename(Literal[1, 1.0, "Hey"]) == "Literal[1, 1.0, Hey]"
 
 
 def test_iter_types():

tests/test_union.py

@@ -2,7 +2,7 @@
 import sys
 from dataclasses import dataclass
 from ipaddress import IPv4Address
-from typing import Dict, Generic, List, Optional, Tuple, TypeVar, Union
+from typing import Dict, Generic, List, Literal, Optional, Tuple, TypeVar, Union
 from uuid import UUID
 
 import pytest
@@ -61,6 +61,16 @@ class ContUnion:
     v: Union[Dict[str, int], List[int], List[str]]
 
 
+@serde
+@dataclass(unsafe_hash=True)
+class LitUnion:
+    """
+    Union of literals
+    """
+
+    v: Union[int, Literal["foo", "bar"]]
+
+
 def test_union():
     v = PriUnion(10)
     s = '{"v":10}'
@@ -128,6 +138,28 @@ def test_union_containers():
     assert v == from_json(ContUnion, s)
 
 
+def test_union_with_literal():
+    v = LitUnion(10)
+    s = '{"v":10}'
+    assert s == to_json(v)
+    assert v == from_json(LitUnion, s)
+
+    v = LitUnion("foo")
+    s = '{"v":"foo"}'
+    assert s == to_json(v)
+    assert v == from_json(LitUnion, s)
+
+    v = LitUnion("bar")
+    s = '{"v":"bar"}'
+    assert s == to_json(v)
+    assert v == from_json(LitUnion, s)
+
+    s = '{"v":"boo"}'
+
+    with pytest.raises(SerdeError):
+        from_json(LitUnion, s)
+
+
 def test_union_with_complex_types():
     @serde
     class A: