Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from pipenv to poetry #115

Closed
yukinarit opened this issue Apr 15, 2021 · 4 comments · Fixed by #144
Closed

Migrate from pipenv to poetry #115

yukinarit opened this issue Apr 15, 2021 · 4 comments · Fixed by #144
Assignees
Labels
ci CI related change enhancement New feature or request

Comments

@yukinarit
Copy link
Owner

Poetry seems be faster and easier to use.

@yukinarit yukinarit added the enhancement New feature or request label Apr 15, 2021
@yukinarit yukinarit self-assigned this Jul 7, 2021
@alexmisk
Copy link
Contributor

alexmisk commented Jul 8, 2021

Hey! If this ticket is not very urgent, can I take it instead of you? :-)

@yukinarit
Copy link
Owner Author

That is very helpful. Thanks! :)

@yukinarit yukinarit added the ci CI related change label Jul 19, 2021
@alexmisk
Copy link
Contributor

Hey! Just want you to know I am working on the migration right now but stuck with the PyPI publishing.

For unknown reason Poetry includes dev dependencies defined in [tool.poetry.dev-dependencies] section in the list of global dependencies. It results in installing a huge list of unnecessary packages on pip install pyserde.

Also the support of installing extra packages from PyPI with Poetry builds (i. e. pip install pyserde[toml]) is tricky.

I hope I can manage these issues in a week or so. Cheers :-)

@yukinarit
Copy link
Owner Author

Thanks for the update! Can you please push to GitHub? I would like to take a look.

@alexmisk alexmisk linked a pull request Jul 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants