Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: change default subtitle language #60

Open
soredake opened this issue Mar 11, 2023 · 3 comments
Open

proposal: change default subtitle language #60

soredake opened this issue Mar 11, 2023 · 3 comments
Assignees

Comments

@soredake
Copy link

soredake commented Mar 11, 2023

Better to change it to something like eng,en,english,en-us to cover more subtitle language naming formats.

@yuroyami
Copy link
Owner

I am not sure what you mean by covering more subtitle language naming formats, but i suppose you mean it should support other formats such as the ISO formats like 'eng' etc. For the time being, the only functioning and required format is IETF BCP 47, this unluckily cannot be changed since the language selection is managed by the underlying player i am using.

The settings right now to adjust the default language for both audio and subtitles do not look great, and it can be confusing, which is why i am replacing both settings with an actual list of languages and the user will only need to select it rather than look up the IETF BCP 47 code and type it, this should cover the same purpose as the subtitle language naming formats i hope

@soredake
Copy link
Author

I am not sure what you mean by covering more subtitle language naming formats

Some subtitles use code en for english some use eng some use english or en-us, i though that "Prefered Subtitle Language" works like in mpv slang='eng,en,en-en,ru-ru' to cover more language codes that can be found in subtitle files.

@yuroyami
Copy link
Owner

My initial understanding was that ExoPlayer uniformly converts subtitle file formats to IETF BCP 47, regardless of any disparities in their original formats. However, now that you said, I am intrigued to experiment with it further

@yuroyami yuroyami self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants