Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove black/flake8/mypy from main dependencies #125

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

takeda
Copy link

@takeda takeda commented Jan 25, 2022

black/flake8/mypy are already listed in dev-dependencies, and listing them in main dependencies propagates to other projects.

This fixes #121

black/flake8/mypy are already listed in dev-dependencies, and listing them in main dependencies propagates to other projects.
@yuval9313 yuval9313 merged commit 6081ac9 into yuval9313:master Feb 2, 2022
@yuval9313
Copy link
Owner

Thanks, I'll hand a new version soon, Also, I think it is dependabot who done this change, I wonder if you might know how to fix it

@takeda takeda deleted the takeda-patch-1 branch February 4, 2022 05:32
@takeda
Copy link
Author

takeda commented Feb 4, 2022

@yuval9313 looking at the history I don't think it was dependabot.

It looks like you invoked:

poetry add mypy@latest

when you probably meant to do:

poetry add -D mypy@latest

Although recommended way would be:

poetry update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] black/flake8/mypy listed as dev and non-dev dependency
2 participants