Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper __version__ #214

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Add proper __version__ #214

merged 2 commits into from
Aug 13, 2023

Conversation

pavelzw
Copy link

@pavelzw pavelzw commented Aug 13, 2023

No description provided.

yuval9313
yuval9313 previously approved these changes Aug 13, 2023
@yuval9313
Copy link
Owner

Please open issue

@pavelzw
Copy link
Author

pavelzw commented Aug 13, 2023

Fixes #215

@pavelzw
Copy link
Author

pavelzw commented Aug 13, 2023

importlib.metadata is not available for python 3.7.
We either kick support for py3.7 since it is at end of life either way or I do a conditional import and use pkg_resources for python 3.7.

What do you prefer @yuval9313?

@yuval9313
Copy link
Owner

We should confirm to @tiangolo's fastapi since these are additional tools to support with the construction of application using fastapi, so as long as they support 3.7 so do we unfortunately

Tho I see as I write it that you found somewhat of a solution to the issue

yuval9313
yuval9313 previously approved these changes Aug 13, 2023
@yuval9313 yuval9313 merged commit aceb178 into yuval9313:master Aug 13, 2023
6 checks passed
@pavelzw pavelzw deleted the pavelzw-patch-1 branch August 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants