Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ShopSmart" text #59

Closed
yuvrajsinghgmx opened this issue Oct 7, 2024 · 7 comments
Closed

"ShopSmart" text #59

yuvrajsinghgmx opened this issue Oct 7, 2024 · 7 comments
Assignees

Comments

@yuvrajsinghgmx
Copy link
Owner

The topbar takes too much space and i think we have two approaches to solve it.

  1. A Creative Idea about the topbar.
  2. Simply reduce the space.

If anyone want to proceed with the first one then he/she must provide a brief and will be also prioritized for this only issue.

@Farhan-Ahmad01
Copy link
Contributor

I also noticed it and would be interested in working on it.
The top bar is currently simple. We can enhance it by adding a search button for users to search for items and update it when a user selects items.
When the user selects items, the top bar changes to show the number of selected items and the delete button.
We can implement something similar to this.
top id

@Farhan-Ahmad01
Copy link
Contributor

Or we can just reduce the extra space taken by the Top-App bar.

@yuvrajsinghgmx
Copy link
Owner Author

yuvrajsinghgmx commented Oct 8, 2024

I also noticed it and would be interested in working on it. The top bar is currently simple. We can enhance it by adding a search button for users to search for items and update it when a user selects items. When the user selects items, the top bar changes to show the number of selected items and the delete button. We can implement something similar to this. top id

We can introduce this.
#54.

@Farhan-Ahmad01
Copy link
Contributor

Ok then please assign it to me, and I'll work on it.

@yuvrajsinghgmx
Copy link
Owner Author

#54 is working on the search feature so please keep this in mind.
I am assigning this to you.

@Farhan-Ahmad01
Copy link
Contributor

Ok, I'll talk to him, there won't be any conflict.

@Farhan-Ahmad01
Copy link
Contributor

Farhan-Ahmad01 commented Oct 10, 2024

I apologize for being late due to my midterms.
I encountered some issues while improving the top-app bar. Changing the height of the top bar looked so straight but it wasn't that easy. I tried a lot, but couldn't figure it out. It will take more time than I thought.
Also, we don't get the same default color in the top bars as it is implemented in the Smart-Bottom navigation bar, so I left it as default for now.
I am making a PR please take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants