Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option merge-other does not work for non-ADS items #44

Closed
syrte opened this issue Aug 16, 2024 · 1 comment
Closed

option merge-other does not work for non-ADS items #44

syrte opened this issue Aug 16, 2024 · 1 comment

Comments

@syrte
Copy link
Contributor

syrte commented Aug 16, 2024

It seems that the option "merge-other" (introduced in #10) does not work for non-ADS items in current adstex.

For example, I cited a book Bishop2006, which is in my personal bib file mylib.bib. Now I want to generate bib file for my paper main.tex. When I run

adstex --force-regenerate --merge-other -o main.bib -r mylib.bib  -P main.tex

In the terminal, adstex prompts

Bishop2006: FOUND IN OTHER BIB SOURCE, MERGED

But in the generated bib file main.bib, Bishop2006 is not there. Clearly, it skipped the "merge" operation...

In contrast, for those normal ads papers in mylib.bib, adstex prompts

Binney2011: FOUND IN SECONDARY BIB SOURCES, UPDATE => 2011MNRAS.413.1889B

And it indeed appears in the generated main.bib as expected.


For reference, the two bib items are attached.

@book{Bishop2006,
  title = {Pattern {{Recognition}} and {{Machine Learning}}},
  author = {Bishop, Christopher M.},
  year = {2006},
  month = aug,
  publisher = {Springer},
  address = {New York},
  isbn = {978-0-387-31073-2},
  langid = {english}
}

@article{Binney2011,
  title = {Models of Our {{Galaxy}} - {{II}}},
  author = {Binney, James and McMillan, Paul},
  year = {2011},
  month = may,
  journal = {Monthly Notices of the Royal Astronomical Society},
  volume = {413},
  pages = {1889--1898},
  issn = {0035-8711},
  doi = {10.1111/j.1365-2966.2011.18268.x},
  urldate = {2023-02-15},
  keywords = {Astrophysics - Astrophysics of Galaxies,galaxies: kinematics and dynamics,Galaxy: disc,Galaxy: kinematics and dynamics,Galaxy: structure},
  annotation = {ADS Bibcode: 2011MNRAS.413.1889B}
}
@syrte syrte changed the title option merge-other does not work option merge-other does not work for non-ADS items Aug 16, 2024
@yymao
Copy link
Owner

yymao commented Aug 19, 2024

Fixed by #45

@yymao yymao closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants