Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Table captions do not respect dark theme #2998

Closed
abstractionmage opened this issue Jul 19, 2022 · 3 comments
Closed

(Bug report) Table captions do not respect dark theme #2998

abstractionmage opened this issue Jul 19, 2022 · 3 comments

Comments

@abstractionmage
Copy link

abstractionmage commented Jul 19, 2022

Trilium Version

0.53.2

What operating system are you using?

Other Linux

What is your setup?

Local + server sync

Operating System Version

Manjaro KDE

Description

welp

Would be cool if I could actually see what I'm typing into table captions without having to switch to a light theme 😅

@zadam
Copy link
Owner

zadam commented Jul 19, 2022

It does actually respect the dark theme:

image

Typical problem is that the table cells have an explicit assigned color which you should be able to clear via cell properties:

image

@abstractionmage
Copy link
Author

abstractionmage commented Jul 20, 2022

Hi, thanks for taking the time. You may have misunderstood me: I'm not talking about header rows, but table captions (enabled by selecting any cell and clicking the "Toogle caption on" button). Those always have dark grey text and a white background regardless of theme. Unless you edit their content, then their background seems to become fully transparent and you can't see what you're typing on dark themes.

caption

@zadam zadam closed this as completed in 1afa325 Jul 20, 2022
@zadam
Copy link
Owner

zadam commented Jul 20, 2022

Hi, you're right, I misunderstood. Table captions are quite new in CKEditor and I didn't add CSS variables for them yet. That should be now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants