From 21548be2e031cb33d121290fddcd850a8c83b915 Mon Sep 17 00:00:00 2001 From: Lukas Niemeier Date: Fri, 5 Jan 2024 10:14:02 +0100 Subject: [PATCH 1/2] Spring 6 and 5 compatibility * upgrade base Spring dependency to Spring 6 * backwards compatibility with Spring 5 (via building against Java 11) * run build and tests against both Spring 6 and 5 --- .github/workflows/build.yaml | 7 +++++-- README.md | 6 +++--- pom.xml | 15 ++++++++++----- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 585d23d..3a794bc 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -18,6 +18,9 @@ env: jobs: build: runs-on: ubuntu-latest + strategy: + matrix: + profile: ['', 'spring5'] steps: - name: Checkout uses: actions/checkout@v3 @@ -25,9 +28,9 @@ jobs: uses: actions/setup-java@v3 with: distribution: temurin - java-version: 11 + java-version: 17 cache: 'maven' - name: Compile run: ./mvnw clean javadoc:javadoc package -DskipTests - name: Test - run: ./mvnw verify -P integration-test -B + run: ./mvnw verify -P "${{ matrix.profile }}" -P integration-test -B diff --git a/README.md b/README.md index a529ca5..74c858d 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ ![Build Status](https://github.com/zalando-stups/baigan-config/workflows/build/badge.svg) [![Maven Central](https://img.shields.io/maven-central/v/org.zalando/baigan-config.svg)](https://maven-badges.herokuapp.com/maven-central/org.zalando/baigan-config) -Baigan configuration is an easy to use configuration framework for [Spring](https://spring.io/) based applications. +Baigan configuration is an easy-to-use configuration framework for [Spring](https://spring.io/) based applications. What makes Baigan a rockstar configuration framework ? @@ -14,8 +14,8 @@ What makes Baigan a rockstar configuration framework ? * AWS S3 ## Prerequisites -- Java 11 -- Spring framework +- Java 17 +- Spring Framework 6 (backwards compatible to 5) - AWS SDK ## Getting started diff --git a/pom.xml b/pom.xml index ebd8d82..fe66b65 100644 --- a/pom.xml +++ b/pom.xml @@ -38,9 +38,12 @@ UTF-8 + 11 + 6.1.2 + 5.3.31 + ${spring6.version} 2.15.1 5.9.3 - 5.3.27 32.0.1-jre 2.0.7 5.3.1 @@ -82,10 +85,6 @@ org.apache.maven.plugins maven-compiler-plugin 3.11.0 - - 11 - 11 - @@ -227,6 +226,12 @@ + + spring5 + + ${spring5.version} + + release From 193daa54130b64f892e94177a077e3128e81512e Mon Sep 17 00:00:00 2001 From: lukasniemeier-zalando Date: Mon, 8 Jan 2024 09:22:11 +0100 Subject: [PATCH 2/2] Update README.md Co-authored-by: Muhammad Hamed --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 74c858d..17295c2 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ What makes Baigan a rockstar configuration framework ? * AWS S3 ## Prerequisites -- Java 17 +- Java 17+ - Spring Framework 6 (backwards compatible to 5) - AWS SDK