Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize tqdm progress bar when verbose=True during scans. #40

Open
MSRudolph opened this issue Apr 12, 2022 · 2 comments
Open

Utilize tqdm progress bar when verbose=True during scans. #40

MSRudolph opened this issue Apr 12, 2022 · 2 comments

Comments

@MSRudolph
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We should replace the print calls when verbose=True in scans with tqdm from the tqdm library. Alternatively, we make it the default and find a way to mute the library's prints.

Describe the solution you'd like

verbose = True  # or False
for it in tqdm(range(n_iters), disable = not verbose):
   ...  # run scans

Additional context
Our verbosity options are currently very rudimentary and tqdm is one of the most used Python libraries.

@mstechly
Copy link
Contributor

I would make sure to check in with some other people on what are the tools they're using for logging, as I know some people did some research on that and would be good to make it consistent across the codebase.

@MSRudolph
Copy link
Contributor Author

@mstechly, what do you mean with tools for logging? This would only print the scan progress in ASCII characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants