Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct friend request #7

Open
zapek opened this issue Sep 30, 2021 · 4 comments
Open

Add direct friend request #7

zapek opened this issue Sep 30, 2021 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@zapek
Copy link
Owner

zapek commented Sep 30, 2021

It should be possible to allow friend requests without exchanging Short Invites first. This is possible because:

  1. the PGP id is in the SSL certificate's issuer field
  2. if the PGP key was gathered through discovery, we can show the profile's name and information
  3. don't forget to verify the signature with the PGP key that we have, otherwise don't even show the requester
@zapek zapek added the feature New feature or request label Sep 30, 2021
@zapek zapek added transport Transport protocol (SSL, Netty, packets and network) and removed transport Transport protocol (SSL, Netty, packets and network) labels Dec 3, 2021
@zapek zapek self-assigned this Feb 13, 2022
@defnax
Copy link

defnax commented Nov 5, 2024

Maybe develope a own Friend request for Xeres?
example how tox do it
https://zetok.github.io/tox-spec/#friend-requests

from Unseen idea:
adding the ability to request/accept friend through DistantChatService.
unsenep2pdev/RetroShare@0e933a5#diff-679d58dcfc4710fa6137de84b6f520b75fa4c623194e924bc149d1ad8017ea7d

@zapek
Copy link
Owner Author

zapek commented Nov 5, 2024

Retroshare allows the following:

  • setup a new location A
  • setup a new location B
  • add B's ShortID in A
  • B will show a connection attempt, accept the friend request
  • A will successfully connect to B

Problems:

  • there's no name displayed in the requester (it could be anybody)
  • there's no vetting by anybody else of the one trying to connect because it's not backed by a PGP key
  • the requests can be spammed (in fact this is one of the first thing I turned off in RS)

So no. I don't think I'll implement it in that way.

@defnax
Copy link

defnax commented Nov 6, 2024

Maybe you can implement the right way or own new way for easier make friends

@defnax
Copy link

defnax commented Nov 6, 2024

for the hstory i dont know if this is useful for Xeres:

Finish Initial implemention of GxsContactList and GxsContact(Invite/Accept/Reject/) with sending Certificates over DistantService Protocol.
sequence:
Contact A-->Add/Invite Contact B.
B Contact-->Approved A's Request or confirm that B has received Certificate with response ACK_REQUEST
If B accepts/approves A's Request -> B send its Certificate to A with APPROVE_REQUEST.
A's receive B's APPROVE_REQUEST, A send back the ACK after add's B as friend.

unsenep2pdev/RetroShare@f668090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants