From 34bd56d09289fde4f593509ced74b9e1c6e645b2 Mon Sep 17 00:00:00 2001 From: Austin Abro Date: Tue, 1 Oct 2024 14:58:21 +0000 Subject: [PATCH] revise comment Signed-off-by: Austin Abro --- src/internal/packager/helm/chart.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/internal/packager/helm/chart.go b/src/internal/packager/helm/chart.go index 1f9fb9a8f0..4470db93b7 100644 --- a/src/internal/packager/helm/chart.go +++ b/src/internal/packager/helm/chart.go @@ -137,10 +137,9 @@ func (h *Helm) InstallOrUpgradeChart(ctx context.Context) (types.ConnectStrings, }) } if !h.chart.NoWait { - // This effectively doubles the amount of time a timeout can take - // 15 minute timeout -> 14 minutes to install -> another 14 minutes of waiting - // This could be avoided by creating the context in the start of the retry loop - // Technically would be a breaking change, in practice this is unlikely to affect anyone + // This re-uses the timeout from helm. This will increase the total amount of time a timeout can take + // However it is unlikely this step will take long + // The other option is to use the same context with as the helm install, this gets tricky with retries healthChecksCtx, cancel := context.WithTimeout(ctx, h.timeout) defer cancel() spinner.Updatef("Running health checks")