Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test import workflow breaks when called from a fork #2952

Closed
AustinAbro321 opened this issue Aug 30, 2024 · 0 comments · Fixed by #2946
Closed

Test import workflow breaks when called from a fork #2952

AustinAbro321 opened this issue Aug 30, 2024 · 0 comments · Fixed by #2946

Comments

@AustinAbro321
Copy link
Contributor

Description

We can see an example of the test import workflow breaking on a fork here - https://github.com/zarf-dev/zarf/actions/runs/10581228147/job/29404470354?pr=2933. This happens because the workflow currently tries to pull the current commit of the PR from the Zarf repo. If the commit is on a fork, then it will not exist on the Zarf repo. Instead we should check if we can import the codebase from a local directory.
image

Severity/Priority

High - we don't want to block outside contributors or have them think their contributions are breaking in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants