Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cluster.PackageSecretNeedsWait #2986

Open
mkcp opened this issue Sep 10, 2024 · 0 comments
Open

Refactor cluster.PackageSecretNeedsWait #2986

mkcp opened this issue Sep 10, 2024 · 0 comments

Comments

@mkcp
Copy link
Contributor

mkcp commented Sep 10, 2024

Describe what should be investigated or refactored

While extracting named returns for #2979 we ran into a method on pkg/cluster/Cluster that had grown a bit unruly (See discussion below). At the moment it doesn't make sense to remove the named returns because they're the most effective documentation for the values themselves. @AustinAbro321 suggested renaming the function to GetWebHookWait - and there's likely a way to simplify the return values and/or provide a wrapper struct to help describe the return values. There's some downstream consumers of the function that could be simplified as well.

Links to any relevant code

(optional) i.e. - https://github.com/zarf-dev/zarf/blob/main/README.md?plain=1#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants