You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
While extracting named returns for #2979 we ran into a method on pkg/cluster/Cluster that had grown a bit unruly (See discussion below). At the moment it doesn't make sense to remove the named returns because they're the most effective documentation for the values themselves. @AustinAbro321 suggested renaming the function to GetWebHookWait - and there's likely a way to simplify the return values and/or provide a wrapper struct to help describe the return values. There's some downstream consumers of the function that could be simplified as well.
Describe what should be investigated or refactored
While extracting named returns for #2979 we ran into a method on
pkg/cluster/Cluster
that had grown a bit unruly (See discussion below). At the moment it doesn't make sense to remove the named returns because they're the most effective documentation for the values themselves. @AustinAbro321 suggested renaming the function toGetWebHookWait
- and there's likely a way to simplify the return values and/or provide a wrapper struct to help describe the return values. There's some downstream consumers of the function that could be simplified as well.Links to any relevant code
(optional) i.e. - https://github.com/zarf-dev/zarf/blob/main/README.md?plain=1#L1
The text was updated successfully, but these errors were encountered: