-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the Demo/Example Vagrant situation #85
Comments
The multi os statement is incorrect. I regularly test the other OS’s and our prime customer isn’t using ubuntu, it’s just handy for dev. We should just add some e2e to cover other OS’s. In fact the e2e runs on amazon linux 2 right now. I have no problem consolidating vagrant files if we need to but am opposed to vagrant for dev. It’s needless complexity to save installing golang. Debug would be harder and it would slow performance. |
Copy on the OSes. Will update. |
@btlghrants thoughts on the other comment about vagrant for dev? I know that's how you really like to operate, and I'm definitely in agreement that it would be pretty valuable for getting new devs spun up quickly. If we said "here's a way you can use Vagrant to do dev of this thing if you want to, but nobody's requiring any particular method" would that make everyone happy? |
I think this would be viable / helpful. Seems like its a matter of what we're willing to support really, so if we don't want to take that on as part of this project then so be it. As you said, though, it's how I plan to operate personally (because I like the isolation) but we don't have to "officially" adopt it if I'm the only one... but it'd be a shame to "waste" the code I'm going to write to make it possible for myself, wouldn't it? I do happen to think it's very helpful to have around for new devs / product evaluators, though. I am not much a fan of requiring people to install just-the-right-version of a programming language runtime when they're, 1) just getting started with a language, or 2) just want to experiment a bit to see if they like a project. Personally, I see making a smoother "on-ramp" as being more-than-worth whatever performance hit we'd take. |
Yeah I'm going to 500% disagree with this. The only way what your stating would be viable is if you actually did your entire dev inside of the VM, i.e. your IDE / tooling as well because golang needs to be installed with the language server to do dev anyway. The only dependency I'm tracking you must have to dev is golang, which your IDE would need to do anything anyway. As far as all your dev inside a VM, tbh, I've never met anyone besides my friend @btlghrants that actually does this. I say this as someone that has 0 lines of code on either system I work on, it's all through remote systems. |
So, if we left the development environment out then, we're saying that Vagrantfiles in Zarf:
|
It's a tough call. For demo-like things it's highly valuable, and good for some dev/testing in isolation. The testing will become more fluid with the native K8s apply work as you will be able to test against any cluster for everything but zarf init. As far as multiple hybervisors, I think we'd just need data to explain why. It's more to support of course, but also I think we'd need to verify the same boxes/version are available and are consistent between the hypervisors. In particular, some dev things rely on VBox folder sync to function |
Keep in mind this issue is just for simplification of the Demo/Example vagrant stuff. The dev environment stuff is #84 and the hypervisor stuff is #86. I'll modify the bullet incorrectly stating that Ubuntu is the only supported OS, then I propose we work this issue separately from #84 and #86 while we work through any differences there. |
Yeah sorry, issue-jacking, saw multiple come in at the same time on my phone |
Updated original description per discussion re OS support |
Yeah I think there will always be a need for vagrant or similar for testing, but my hope is that all early evaluation/demo/dev stuff can just use the local cluster of your choice. |
closing vagrant issues as we move towards more non-vm testing/examples. |
What/Why
We should not specify other OSes if we aren't investing in making sure they are supported. Let's slim down to just Ubuntu for now, then add new OSes one at a time as we want to support themExistence implies support, which isn't true right now for several of the OSes in the root VagrantfileCo-authored with @btlghrants
The text was updated successfully, but these errors were encountered: