From 36f34a41a59e1983f25e230350eb80d6ec3f181f Mon Sep 17 00:00:00 2001 From: Austin Abro Date: Thu, 1 Aug 2024 18:48:27 +0000 Subject: [PATCH 1/2] better name jobs Signed-off-by: Austin Abro --- .github/workflows/dependency-review.yml | 2 +- .github/workflows/nightly-ecr.yml | 2 +- .github/workflows/nightly-eks.yml | 2 +- .github/workflows/release.yml | 4 ++-- .github/workflows/scan-codeql.yml | 2 +- .github/workflows/scan-docs-and-schema.yml | 2 +- .github/workflows/scan-lint.yml | 2 +- .github/workflows/test-bigbang.yml | 4 ++-- .github/workflows/test-e2e.yml | 2 +- .github/workflows/test-external.yml | 2 +- .github/workflows/test-site.yml | 2 +- .github/workflows/test-unit.yml | 2 +- .github/workflows/test-upgrade.yml | 4 ++-- 13 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml index 01843002e6..fec97b77c3 100644 --- a/.github/workflows/dependency-review.yml +++ b/.github/workflows/dependency-review.yml @@ -6,7 +6,7 @@ permissions: contents: read jobs: - validate: + dependency-review: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/nightly-ecr.yml b/.github/workflows/nightly-ecr.yml index 9ff144c4ff..ca9bf97ca4 100644 --- a/.github/workflows/nightly-ecr.yml +++ b/.github/workflows/nightly-ecr.yml @@ -15,7 +15,7 @@ permissions: contents: read jobs: - validate: + ecr-nightly-test: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/nightly-eks.yml b/.github/workflows/nightly-eks.yml index 18b23bb1c6..3ea9aae5a9 100644 --- a/.github/workflows/nightly-eks.yml +++ b/.github/workflows/nightly-eks.yml @@ -23,7 +23,7 @@ concurrency: cancel-in-progress: true jobs: - validate: + eks-nightly-test: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cc5d405a95..c5700a167e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -9,7 +9,7 @@ on: - "v*" jobs: - build: + build-release: runs-on: ubuntu-latest permissions: packages: write @@ -78,7 +78,7 @@ jobs: path: build/ retention-days: 1 - validate: + validate-release: runs-on: ubuntu-latest needs: build steps: diff --git a/.github/workflows/scan-codeql.yml b/.github/workflows/scan-codeql.yml index 4f651e704a..e5ab9bd6d8 100644 --- a/.github/workflows/scan-codeql.yml +++ b/.github/workflows/scan-codeql.yml @@ -30,7 +30,7 @@ on: - cron: "32 2 * * 5" jobs: - validate: + codeql-scan: runs-on: ubuntu-latest permissions: actions: read diff --git a/.github/workflows/scan-docs-and-schema.yml b/.github/workflows/scan-docs-and-schema.yml index e614faa5a1..c4819b6525 100644 --- a/.github/workflows/scan-docs-and-schema.yml +++ b/.github/workflows/scan-docs-and-schema.yml @@ -7,7 +7,7 @@ permissions: contents: read jobs: - validate: + validate-docs-and-schema: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/scan-lint.yml b/.github/workflows/scan-lint.yml index 45421e95de..95642fe5cc 100644 --- a/.github/workflows/scan-lint.yml +++ b/.github/workflows/scan-lint.yml @@ -7,7 +7,7 @@ permissions: contents: read jobs: - validate: + lint: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/test-bigbang.yml b/.github/workflows/test-bigbang.yml index 34e7ac5ca5..2bc6c2e667 100644 --- a/.github/workflows/test-bigbang.yml +++ b/.github/workflows/test-bigbang.yml @@ -30,7 +30,7 @@ concurrency: cancel-in-progress: true jobs: - build: + build-bigbang: runs-on: ubuntu-latest steps: - name: Checkout @@ -69,7 +69,7 @@ jobs: path: build/ retention-days: 1 - validate: + validate-bigbang: runs-on: ubuntu-latest needs: build steps: diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 91a5f160a4..93041c45fc 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -31,7 +31,7 @@ concurrency: jobs: # Build the binary and init package - build: + build-e2e: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/test-external.yml b/.github/workflows/test-external.yml index 081ac7c461..2db9dcbcd3 100644 --- a/.github/workflows/test-external.yml +++ b/.github/workflows/test-external.yml @@ -30,7 +30,7 @@ concurrency: cancel-in-progress: true jobs: - validate: + validate-external: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/test-site.yml b/.github/workflows/test-site.yml index 1042f3a0b6..fcacbfee38 100644 --- a/.github/workflows/test-site.yml +++ b/.github/workflows/test-site.yml @@ -12,7 +12,7 @@ concurrency: cancel-in-progress: true jobs: - validate: + validate-site: runs-on: ubuntu-latest defaults: run: diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml index 78b49b9c90..4690674604 100644 --- a/.github/workflows/test-unit.yml +++ b/.github/workflows/test-unit.yml @@ -34,7 +34,7 @@ concurrency: cancel-in-progress: true jobs: - validate: + validate-unit: runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/test-upgrade.yml b/.github/workflows/test-upgrade.yml index 3ffe41a13c..7c3d6baf02 100644 --- a/.github/workflows/test-upgrade.yml +++ b/.github/workflows/test-upgrade.yml @@ -30,7 +30,7 @@ concurrency: cancel-in-progress: true jobs: - build: + build-upgrade: runs-on: ubuntu-latest steps: - name: Checkout @@ -52,7 +52,7 @@ jobs: path: build/ retention-days: 1 - validate: + validate-upgrade: runs-on: ubuntu-latest needs: build steps: From 92bcd57b668911d9d0fbaef6a07bac14857736b3 Mon Sep 17 00:00:00 2001 From: Austin Abro Date: Thu, 1 Aug 2024 19:15:34 +0000 Subject: [PATCH 2/2] needs was incorrect Signed-off-by: Austin Abro --- .github/workflows/release.yml | 6 +++--- .github/workflows/test-bigbang.yml | 2 +- .github/workflows/test-e2e.yml | 10 +++++----- .github/workflows/test-upgrade.yml | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c5700a167e..8da6cbc22b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -80,7 +80,7 @@ jobs: validate-release: runs-on: ubuntu-latest - needs: build + needs: build-release steps: # Checkout the repo and setup the tooling for this job - name: Checkout @@ -114,9 +114,9 @@ jobs: if: always() uses: ./.github/actions/save-logs - push: + create-release: runs-on: ubuntu-latest - needs: validate + needs: validate-release environment: release permissions: contents: write diff --git a/.github/workflows/test-bigbang.yml b/.github/workflows/test-bigbang.yml index 2bc6c2e667..451a2082a9 100644 --- a/.github/workflows/test-bigbang.yml +++ b/.github/workflows/test-bigbang.yml @@ -71,7 +71,7 @@ jobs: validate-bigbang: runs-on: ubuntu-latest - needs: build + needs: build-bigbang steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 93041c45fc..b3fee07a16 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -55,7 +55,7 @@ jobs: validate-without-cluster: runs-on: ubuntu-latest - needs: build + needs: build-e2e steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -90,7 +90,7 @@ jobs: # Run the tests on k3d validate-k3d: runs-on: ubuntu-latest - needs: build + needs: build-e2e steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -128,7 +128,7 @@ jobs: # Run the tests on k3s validate-k3s: runs-on: ubuntu-latest - needs: build + needs: build-e2e steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -166,7 +166,7 @@ jobs: # Run the tests on kind validate-kind: runs-on: ubuntu-latest - needs: build + needs: build-e2e steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -206,7 +206,7 @@ jobs: # Run the tests on minikube validate-minikube: runs-on: ubuntu-latest - needs: build + needs: build-e2e steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 diff --git a/.github/workflows/test-upgrade.yml b/.github/workflows/test-upgrade.yml index 7c3d6baf02..a86c02e5cc 100644 --- a/.github/workflows/test-upgrade.yml +++ b/.github/workflows/test-upgrade.yml @@ -54,7 +54,7 @@ jobs: validate-upgrade: runs-on: ubuntu-latest - needs: build + needs: build-upgrade steps: - name: Checkout uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7