Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use run.io_bound and run.cpu_bound from NiceGUI to avoid code duplication #43

Closed
rodja opened this issue Oct 15, 2023 · 2 comments · Fixed by #177
Closed

Use run.io_bound and run.cpu_bound from NiceGUI to avoid code duplication #43

rodja opened this issue Oct 15, 2023 · 2 comments · Fixed by #177
Assignees
@falkoschindler
Labels
enhancement New feature or request
Milestone
0.15.0

Comments

@rodja
Copy link
Member

rodja commented Oct 15, 2023

We have made run.io_bound and run.cpu_bound available in NiceGUI and should remove the code duplication in RoSys.
@rodja rodja added the enhancement New feature or request label Oct 15, 2023
@rodja rodja added this to the 0.9.3 milestone Oct 15, 2023
@falkoschindler falkoschindler self-assigned this Oct 19, 2023
@falkoschindler
Copy link
Contributor

falkoschindler commented Oct 24, 2023 •
edited
Loading

I had to revert my commit because it broke tests in other projects.
Especially running_cpu_bound_processes needs to be updated so that the tests wait for completion.
But maybe there are more things to consider.

@rodja rodja reopened this Nov 3, 2023
@rodja rodja modified the milestones: 0.9.3, 0.9.4 Nov 3, 2023
@rodja rodja modified the milestones: 0.9.5, 0.9.6 Nov 26, 2023
@rodja rodja modified the milestones: 0.9.6, 0.9.7 Dec 22, 2023
@rodja
Copy link
Member Author

rodja commented Feb 15, 2024

It would be great to have a minimal example to test the problematic cases.

@rodja rodja mentioned this issue Aug 4, 2024
Closed
@falkoschindler falkoschindler added this to the 0.15.0 milestone Aug 19, 2024
@falkoschindler falkoschindler mentioned this issue Aug 19, 2024
Merged
@falkoschindler falkoschindler linked a pull request Aug 19, 2024 that will close this issue
Use NiceGUI's run.io_bound and run.cpu_bound #177
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falkoschindler falkoschindler

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Use NiceGUI's run.io_bound and run.cpu_bound zauberzeug/rosys
2 participants
@rodja @falkoschindler