-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: offer a more generic popup window #65
Comments
Hi, What more would you like to do? |
This has multiple issues that I've found, probably not all related to here (because that's the first time I try this library in years ) :
See attached video and sample project: 2019-08-01_16-06-13.zip Sadly I do have to use minSdk as 16 . Why did you have a jump to 19 ? All Android libraries are for at least 16 . Not 19... :( |
Well, 4.1-4.3 accounts for 3% of users and this number is diminishing. I'm not sure that ALL Android libraries are min 16 ;) Supporting older versions also costs time. You are free to fork the library and change min SDK to 16 and see if it still works. No guarantees though.
You can when using
This is actually not a feature of this library - it only binds itself to the views and not touch location. You might try calculating the offsets and using them to construct the popup menu with |
Well 3% out of at least 2.5 active devices is still a lot, and the support library is from API 14. The only ones that's from 16 are of something related to Admob or other Google services. What did you need to use, that you switched to 19? Sadly this library uses a syntax I'm not aware of, instead of normal function calls, so it's harder to see what's available this way. 2019-08-01_16-06-13.zip About the bugs, why do you say it's a feature? Scrolling on its own is a feature? Why should it scroll? Please, if you think it's easy, can you please update the samples to show how to deal with those? |
I was referring to the click location, I missed the part about scrolling issue.
I'm not sure if I understand this but basically you would like this component to behave like a ContextMenu? I'm not sure if it's possible to have it behave like that out of the box. At least I don't see a way, but I'll welcome any contributions regarding this! Regarding dropping support below API 19 - as explained in comment before supporting older OS version costs time. You need to test before each release on each version. The projects I'm working on are API 21+ actually and most project I know are API 19 at minimum. Again feel free to fork the library if you need API 16 support or you can use an older version of the library (3.4.0) - https://github.com/zawadz88/MaterialPopupMenu/blob/master/CHANGELOG.md |
OK got it except the touch issue, using the support library and a workaround . Repository here, if you want to look at: |
Sometimes we would like to have our own very customized view to show in the popup.
Please offer what you have today, with the nice alignment , auto-positioning etc... - for a more generic popup.
The text was updated successfully, but these errors were encountered: