-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time warp fails on short spectrogram #12
Comments
It seems the implementation in this source code differs from the approach taken from in the above tensorflow implementation. This repo uses 2 points for fitting the transform, whereas the tf code uses multiple points |
Great catch @PrathamSoni . Please feel free to PR. I'm afraid I have too much on my plate to fix this module. |
@zcaceres Will open the PR within the next couple of days. This line in the bilinear interpolation is also deprecated (copying tensor from construct). I can patch that as well. |
Got same situation. This BUG seriously affects the model performance. Any updates? @PrathamSoni |
@keshawnhsieh just put up the pr. Could you let me know if it works better? |
Many thanks. I will test it after Chinese New Year. |
Fantastic @PrathamSoni . Thanks so much. |
@thread especially @keshawnhsieh, I've made some fixes to the pull request. I think it should work perfectly now. LMK if you try it out! |
Hi, I have a question whether the time warping can sometimes cause a spectrogram to be too distorted or not.
I applied Time Warping with W=2 and it sometimes results in ugly padding on the right side of the spectrogram. Is there any way to alleviate this problem?
The text was updated successfully, but these errors were encountered: