Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_disabled_keymap_binding fails on Linux with "Invalid keystroke cmd-k" #10427

Closed
1 task done
jansol opened this issue Apr 11, 2024 · 2 comments
Closed
1 task done
Labels
defect [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc linux setting Feedback for preferences, configuration, etc

Comments

@jansol
Copy link
Contributor

jansol commented Apr 11, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

failures:

---- zed::tests::test_disabled_keymap_binding stdout ----
thread 'zed::tests::test_disabled_keymap_binding' panicked at crates/zed/src/zed.rs:664:48:
called Result::unwrap() on an Err value: Invalid keystroke cmd-k
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

failures:
zed::tests::test_disabled_keymap_binding

test result: FAILED. 17 passed; 1 failed; 0 ignored; 0 measured; 1 filtered out; finished in 3.34s

Found over in NixOS/nixpkgs#303233 where it causes the checkPhase of the package build process to fail.

While we can simply disable the test for packaging purposes, I think this kind of "invalid" keymap should be handled gracefully in Zed (incl. tests).

Environment

NixOS unstable
Linux 6.8, both aarch64 and x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@jansol jansol added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 11, 2024
@Luk-ESC
Copy link

Luk-ESC commented Apr 11, 2024

Looks like the same issue as #10382, which seems to actually affect users.

@JosephTLyons JosephTLyons added linux setting Feedback for preferences, configuration, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 11, 2024
@mikayla-maki
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc linux setting Feedback for preferences, configuration, etc
Projects
None yet
Development

No branches or pull requests

4 participants