Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blade: Outline rendering for 1 pixel borders is not being rasterized properly #11056

Open
1 task done
DissolveDZ opened this issue Apr 26, 2024 · 4 comments
Open
1 task done
Labels
defect [core label] linux workspace Feedback for workspace management, layout, interactions, etc

Comments

@DissolveDZ
Copy link
Contributor

DissolveDZ commented Apr 26, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I tried Zed on Windows and have seen screenshots of it on Mac so i believe it's a Linux related issue on both X11 and Wayland.
(Note that on Windows after some testing I've noticed the right side consistently being thinner, although it never disappears like on Linux)

The right side of any outline, which should be 1px in length both for popups and hollow cursor outline, doesn't show half of the time.

Environment

Zed: v1.0.0 (Zed Dev 2c1b961)
OS: Linux 1.0.0
Memory: 23.4 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

outline cursor half of the time:
image

the other half it looks like this (right side thinner):

image

the exact same goes for hover popups, also always the right side.
(couldn't take any screenshots because it kept on closing)

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@DissolveDZ DissolveDZ added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 26, 2024
@DissolveDZ DissolveDZ changed the title linux / blade: Outline rendering for 1 pixel borders is not being rasterized properly blade: Linux outline rendering for 1 pixel borders is not being rasterized properly Apr 26, 2024
@JosephTLyons JosephTLyons added linux workspace Feedback for workspace management, layout, interactions, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 26, 2024
@DissolveDZ DissolveDZ changed the title blade: Linux outline rendering for 1 pixel borders is not being rasterized properly blade: Outline rendering for 1 pixel borders is not being rasterized properly Apr 27, 2024
@apricotbucket28
Copy link
Contributor

apricotbucket28 commented Apr 29, 2024

I can also see rendering issues with some icons, here's from the inline git blame:
image
It only happens with some lines.

Edit: Here's the issue on the project panel
image

@DissolveDZ
Copy link
Contributor Author

this might be due to the zooming logic, at certain zoom levels it actually behaves perfectly as expected, squiggly lines and folding indicators also tend to break but at these levels everything is perfect.

example of one of those zoom levels

image

@apricotbucket28
Copy link
Contributor

apricotbucket28 commented May 18, 2024

Just got this while working on some X11 stuff. It mostly seems to happen with icons.

image

Edit: Another quick way to see this is with the LSP loading indicator at the bottom:
image

@kvark
Copy link
Contributor

kvark commented Sep 7, 2024

Could somebody grab a RenderDoc capture of this happening, please, and share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] linux workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

4 participants