Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test task is run incorrectly on linux #11481

Closed
1 task done
sigmaSd opened this issue May 7, 2024 · 3 comments
Closed
1 task done

test task is run incorrectly on linux #11481

sigmaSd opened this issue May 7, 2024 · 3 comments
Labels
defect [core label] linux tasks terminal Feedback for terminal integration, shell commands, etc

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented May 7, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Running a test task on linux fails like this

⏵ Task `cargo test -p qsdsq hello -- --nocapture` finished with non-zero error code: 127
⏵ Command: '/usr/bin/fish -i -c `cargo test -p qsdsq hello -- --nocapture`'

The problem seems to be that the shell script is quoted with ` instead of " or '

Maybe thats a macos thing ?

The relevant code

spawn_task.command_label = format!("{shell} -i -c `{}`", spawn_task.command_label);

Environment

Zed: v1.0.0 (Zed Nightly c68b700)
OS: Linux 1.0.0
Memory: 7.6 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@sigmaSd sigmaSd added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 7, 2024
@sigmaSd
Copy link
Contributor Author

sigmaSd commented May 7, 2024

Actually for some reason cargo run task works:

⏵ Task `cargo run` finished successfully
⏵ Command: '/usr/bin/fish -i -c `cargo run`'

If I spawn the same command manually it errors (it works if I change the quotes)

/usr/bin/fish -i -c `cargo run`
fish: `cargo: command not found...

@Moshyfawn Moshyfawn added terminal Feedback for terminal integration, shell commands, etc linux platform support An umbrella label for all platforms tasks and removed triage Maintainer needs to classify the issue labels May 8, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label May 9, 2024
@JosephTLyons JosephTLyons removed the platform support An umbrella label for all platforms label May 22, 2024
@mrnugget
Copy link
Member

mrnugget commented Jun 3, 2024

I think the problem is more that we don't support fish in tasks yet, right @osiewicz? The quotes in that window aren't the actual quotes used.

@osiewicz
Copy link
Contributor

osiewicz commented Jun 3, 2024

Yeah, that's essentially it. So it's a duplicate of #10964

@mrnugget mrnugget closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] linux tasks terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests

5 participants