Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin and check hash for downloaded binaries #13918

Open
1 task done
imbev opened this issue Jul 7, 2024 · 0 comments
Open
1 task done

Pin and check hash for downloaded binaries #13918

imbev opened this issue Jul 7, 2024 · 0 comments
Labels
enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc security & privacy Data privacy issue, security vulnerabilities, etc

Comments

@imbev
Copy link

imbev commented Jul 7, 2024

Check for existing issues

  • Completed

Describe the feature

In order to provide support for language servers and various tools, Zed automatically downloads binaries from the internet without user approval. To mitigate some security risks, I suggest that Zed pin and check the hashes for all downloaded binaries.

zed::download_file could be changed to require a sha256 hash. Usage of zed::latest_github_release could be replaced by a function returning the binary release url for a given tag or release. The supermaven download could be removed or replaced by a verified mirror.

References:

@imbev imbev added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jul 7, 2024
@JosephTLyons JosephTLyons added extension infrastructure Feedback for extensions APIs, creation, management, etc security & privacy Data privacy issue, security vulnerabilities, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc security & privacy Data privacy issue, security vulnerabilities, etc
Projects
None yet
Development

No branches or pull requests

2 participants