Some TypeScript code actions are not applied #20384
Comments
mykytabatrak
added
admin read
mykytabatrak
changed the title
JosephTLyons
added
typescript
|
First of all: thank you for this perfect issue! I have to call this out: reproducible steps, a repo (!), videos (!!) — thank you! Now, as to your problem: yes, given the settings you provided, the code actions don't work with Instead of {
"format_on_save": "on",
"code_actions_on_format": {
"source.addMissingImports": true,
"source.removeUnusedImports": true,
"source.sortImports": true
}
}Try this: {
"format_on_save": "on",
"code_actions_on_format": {
"source.organizeImports": true
}
}That works for me: screenshot-2024-11-11-18.41.41.mp4 |
|
That's what I thought. Do you know if these actions are compatible with typescript-language-server? Because it seems like they aren't from my testing that I outlined in the issue's description. My issue is that on my job we have eslint config that defines rules for import order, and for files with large amount of imports eslint and "source.organizeImports" run into a race condition where the latter sometimes wins and I get an error in our CI/CD chain. I have to manually disable "source.organizeImports", format the file and then re-enable it because I need it to remove unused imports. |
|
Have you tried using the code actions as the formatter? You can define multiple formatters, for example, and then specify a order in which they are applied: {
"TypeScript": {
"formatter": [
{ "language_server": { "name": "vtsls" } },
{
"code_actions": {
"source.organizeImports": true,
"source.fixAll.eslint": true
}
}
]
}
} |
Check for existing issues
Describe the bug / provide steps to reproduce it
When using
"code_actions_on_format"in.ts, or.tsxfiles only"source.organizeImports"actually modifies the code.Zed settings:
{ "format_on_save": "on", "code_actions_on_format": { "source.addMissingImports": true, "source.removeUnusedImports": true, "source.sortImports": true } }Repository I used for reproducing - https://github.com/mykytabatrak/zed-ts-code-actions.
I set up two files with a bunch of imports that need formatting:
src/main.tsxandsrc/test.ts. With"source.organizeImports"imports get sorted and unused one are removed, while"source.addMissingImports","source.removeUnusedImports", and"source.sortImports"do not affect the code in any way.Also, I took a look at the vtsls code and I am not sure that it supports three actions I outlined above, so as per documentation I configured Zed to use typescript-language-server, and tried formatting code with the following configuration:
{ "languages": { "TypeScript": { "language_servers": ["typescript-language-server", "!vtsls"], "prettier": { "allowed": false } }, "TSX": { "language_servers": ["typescript-language-server", "!vtsls"], "prettier": { "allowed": false } }, "JavaScript": { "language_servers": ["typescript-language-server", "!vtsls"], "prettier": { "allowed": false } } }, "format_on_save": "on", "code_actions_on_format": { "source.addMissingImports": true, "source.removeUnusedImports": true, "source.sortImports": true } }Unfortunately results were the same.
Environment
Zed: v0.160.7 (Zed)
OS: macOS 15.1.0
Memory: 36 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
First video is using Zed config with only code actions specified:
output.mov
Second video is with typescript-language-server configured in Zed:
output-2.mov
If applicable, attach your Zed.log file to this issue.
Zed.log
The text was updated successfully, but these errors were encountered: