Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error underline looks bad #7436

Open
1 task done
widersky opened this issue Feb 6, 2024 · 6 comments
Open
1 task done

The error underline looks bad #7436

widersky opened this issue Feb 6, 2024 · 6 comments
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc

Comments

@widersky
Copy link

widersky commented Feb 6, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  1. Just look at any underline decoration 😅

My settings.json:

{
  "show_copilot_suggestions": true,
  "terminal": {
    "dock": "bottom"
  },
  "project_panel": {
    "dock": "left",
    "folder_icons": false
  },
  "buffer_font_family": "Fira Code",
  "buffer_font_size": 12,
  "ui_font_family": "Inter",
  "ui_font_size": 15,
  "theme": "One Light",
  "autosave": "off",
  "format_on_save": "off",
  "buffer_line_height": "comfortable",
  "tab_size": 2,
  "confirm_quit": true,
  "show_whitespaces": "all",
  "wrap_guides": [100],
  "features": {
    "copilot": true
  },
  "tabs": {
    "close_position": "left",
    "git_status": true
  },
  "assistant": {
  }
}

Environment

Zed: v0.121.3 (Zed Preview)
OS: macOS 14.3.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@widersky widersky added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Feb 6, 2024
@rev4324
Copy link

rev4324 commented Feb 6, 2024

The issue seems to occur only when the active display is LoDPI.
MacBook's 2x scaled HiDPI display:
image
External 1x 1440p LoDPI display:
image

@JosephTLyons JosephTLyons added design [core label] diagnostics Feedback for diagnostics, error messages, logs, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 6, 2024
@widersky
Copy link
Author

image

This is how it's looking when issue occurs on single character - is almost invisible.

@doctopus
Copy link

doctopus commented Jun 7, 2024

Is there a setting to disable the error underlines completely?

@Moshyfawn Moshyfawn added editor Feedback for code editing, formatting, editor iterations, etc defect [core label] and removed defect [core label] design [core label] labels Jun 10, 2024
@KraXen72
Copy link

KraXen72 commented Jul 9, 2024

this also happens for me on fedora 40, kde plasma 6, wayland on a 1440p 100% scaled display.

@forGGe
Copy link

forGGe commented Jul 12, 2024

Would be really nice if the style of diagnostic errors/warnings was customizable. I believe #365 / #366 made the style hardcoded as wavy, and I can't find any settings related to changing that.

@Braymatter
Copy link

Braymatter commented Jul 12, 2024

This also happens for me.

I would love to have the error text actually inlay under the line. I hate having to have either a full editor pane dedicated to errors, or hover my mouse over the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc
Projects
None yet
Development

No branches or pull requests

8 participants