Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing escape should dismiss the "do you want to save" prompt #9203

Closed
1 task done
jansol opened this issue Mar 11, 2024 · 4 comments
Closed
1 task done

Pressing escape should dismiss the "do you want to save" prompt #9203

jansol opened this issue Mar 11, 2024 · 4 comments
Labels
enhancement [core label] linux workspace Feedback for workspace management, layout, interactions, etc

Comments

@jansol
Copy link
Contributor

jansol commented Mar 11, 2024

Check for existing issues

  • Completed

Describe the feature

#8980 adds a custom prompt when closing a file with unsaved changes. Normally pressing the escape key on such prompts has the same result as clicking on the cancel button. This is currently not the case. (nothing happens)

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@jansol jansol added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Mar 11, 2024
@Moshyfawn Moshyfawn added workspace Feedback for workspace management, layout, interactions, etc and removed triage Maintainer needs to classify the issue labels Mar 11, 2024
@jadijadi
Copy link
Contributor

May I ask about your OS & Zed version?
In my case pressing Esc acts like Cancel.

Zed version: 0.126
OS: Mac

@jansol
Copy link
Contributor Author

jansol commented Mar 12, 2024

This is specific to the custom prompts added in #8980 which are used on Linux. I think macOS still uses the system-provided prompts?

@jadijadi
Copy link
Contributor

Right. tested on a Linux machine too. You are right. On Mac we use the system-provided prompt and htis happens on Linux.

@ConradIrwin
Copy link
Member

This should be fixed on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] linux workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

5 participants